On Wednesday 12 November 2014 20:16:06, Arnd Bergmann wrote: > On Wednesday 12 November 2014 17:38:31 Alexander Stein wrote: > > On Wednesday 12 November 2014 17:04:57, Arnd Bergmann wrote: > > > On Wednesday 12 November 2014 17:02:56 Alexander Stein wrote: > > > > This features already exists for board config setups. Add support for > > > > device tree based systems. > > > > > > > > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx> > > > > --- > > > > Please note: Due to current lack of hardware I could not test it yet. V2 > > > > includes the changes proposed by Dmitry. > > > > > > > > Changes in v2: > > > > * Added device tree bindings > > > > * IRQ is only parsed and mapped when there is no "gpios" property > > > > > > > > > > Can you list one or more examples in the patch description? > > > Are these systems that don't expose the GPIO controller with a > > > standalone driver, or systems that really actually connect the > > > buttons to an interrupt pin? > > > > You mean a use case? I came to this situation to test interrupt polarity on a microcontroller, thus a simple /IRQ pin, no GPIO at all. So in the end I have an input just connected to an interrupt line. > > I noticed gpio_keys using platform data only can be used for this setup. So I added this support for device tree. > > > > I meant a specific board file that uses this, which can't be converted > to DT without your change. I've searched (hopefully) the complete arch/ tree on v3.18-rc4 for struct gpio_keys_button and checked each occurrence. I didn't found any usage of IRQ based input keys. Best regards, Alexander -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
