On Thu, Nov 13, 2014 at 9:24 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Hi, > > On 11/13/2014 09:52 AM, Maxime Ripard wrote: >> On Wed, Nov 12, 2014 at 11:08:43PM +0100, Hans de Goede wrote: >>> One of the reasons for having the simplefb nodes in /chosen, and doing >>> explicit enumeration of the nodes there, is too allow enumerating them sooner, >>> so that we get a console earlier on. >>> >>> Doing this earlier then fs_initcall is not useful, since the fb only turns into >>> a console when fbcon intializes, which is a fs_initcall too. >>> >>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >>> --- >>> drivers/video/fbdev/simplefb.c | 6 +++++- >>> 1 file changed, 5 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c >>> index be7d288..8c0c972 100644 >>> --- a/drivers/video/fbdev/simplefb.c >>> +++ b/drivers/video/fbdev/simplefb.c >>> @@ -415,7 +415,11 @@ static void __exit simplefb_exit(void) >>> platform_driver_unregister(&simplefb_driver); >>> } >>> >>> -module_init(simplefb_init); >>> +/* >>> + * While this can be a module, if builtin it's most likely the console >>> + * So let's leave module_exit but move module_init to an earlier place >>> + */ >> >> Not really related to this patch itself, but do we want to support >> simplefb as a module? It seems like it's going to be most of the time >> broken. > > A valid point, my mean reasoning here is that some may see not being able to > use it as a module as a regression, so I just kept things as is, but I do > agree that it is advisable to just build it in. Like a lot of things, if it is made a modules, and it breaks for the user, the user gets to keep the pieces. There are potentially some valid scenarios where it is fine to have it as a module. I don't recommend changing this unless is actually starts causing problems. g. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
