On 09/02/2023 16:45, Ryan.Wanner@xxxxxxxxxxxxx wrote: > From: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx> Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). > > Adding macros for sama7g drive strength. > > Signed-off-by: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx> > --- > include/dt-bindings/pinctrl/at91.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h > index e8e117306b1b..fd0a389b2a0f 100644 > --- a/include/dt-bindings/pinctrl/at91.h > +++ b/include/dt-bindings/pinctrl/at91.h > @@ -42,8 +42,14 @@ > #define AT91_PERIPH_C 3 > #define AT91_PERIPH_D 4 > > -#define ATMEL_PIO_DRVSTR_LO 1 That's an ABI break, so no. You need to keep it. > +#define ATMEL_PIO_DRVSTR_LO_0 0 > +#define ATMEL_PIO_DRVSTR_LO_1 1 > #define ATMEL_PIO_DRVSTR_ME 2 > #define ATMEL_PIO_DRVSTR_HI 3 > > +#define ATMEL_PIO_DRVSTR_LO_D 0 > +#define ATMEL_PIO_DRVSTR_HI_A 1 > +#define ATMEL_PIO_DRVSTR_LO_C 2 > +#define ATMEL_PIO_DRVSTR_LO_B 3 Explanation for all of these would be useful, it's a bit of cryptic. Best regards, Krzysztof
