On 09/02/2023 02:22, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > There are no compatible for "reg/reg-names" and "clock-name" > between previous R-Car series and R-Car Gen4. > > "reg/reg-names" needs 3 categorize (for Gen1, for Gen2/Gen3, for Gen4), > therefore, use 3 if-then to avoid nested if-then-else. > > Move "clock-name" property to under allOf to use if-then-else. > > Link: https://lore.kernel.org/all/87zg9vk0ex.wl-kuninori.morimoto.gx@xxxxxxxxxxx/#r > Link: https://lore.kernel.org/all/87r0v2uvm7.wl-kuninori.morimoto.gx@xxxxxxxxxxx/#r > Link: https://lore.kernel.org/all/87r0v1t02h.wl-kuninori.morimoto.gx@xxxxxxxxxxx/#r > Reported-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > --- > .../bindings/sound/renesas,rsnd.yaml | 80 +++++++++++++++---- > 1 file changed, 65 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > index 12ccf29338d9..5fd6435f4873 100644 > --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > @@ -99,20 +99,6 @@ properties: > minItems: 1 > maxItems: 31 > > - clock-names: > - description: List of necessary clock names. > - minItems: 1 > - maxItems: 31 No improvements here. Your argument that you need to remove it to customize is not correct. https://elixir.bootlin.com/linux/v5.19-rc6/source/Documentation/devicetree/bindings/clock/samsung,exynos7-clock.yaml#L57 Best regards, Krzysztof
