On 07/02/2023 07:08, Greg KH wrote: > On Tue, Feb 07, 2023 at 08:36:47AM +0800, Zhou Furong wrote: >> >> >> On 2023/2/6 18:26, Greg KH wrote: >>> On Mon, Feb 06, 2023 at 05:49:44PM +0800, Zhou Furong wrote: >>>> >>>>>> + >>>>>> +#include <linux/device.h> >>>>>> +#include <linux/module.h> >>>>>> +#include <linux/of.h> >>>>>> +#include <linux/of_device.h> >>>>>> +#include <linux/slab.h> >>>>>> +#include <linux/wiegand.h> >>>>>> +#include <linux/dma-mapping.h> >>>>>> +#include <linux/dmaengine.h> >>>>>> +#include <linux/property.h> >>>>>> + >>>> >>>> please order headers >>> >>> Why? What order? For what gain > >> >> If all header file ordered in alphabet, it will be easy to find if a header >> file has been included or not when header file list is long. > > That's what search in your editor is for :) > > This is not a real problem with this code, sorry. I would say the only argument is reducing conflicts for simultaneous edits, mostly when adding new headers. If everyone add at the end, you get conflicts which could not happen if entries were ordered. Another thing is that actual order allows easier to spot duplicates or unneeded headers by looking. At least to me it's easier to read. Best regards, Krzysztof
