On Tue, Feb 07, 2023 at 12:20:59PM +0200, Andy Shevchenko wrote: > On Mon, Feb 06, 2023 at 05:41:56PM -0800, Saravana Kannan wrote: > > Registering an irqdomain sets the flag for the fwnode. But having the > > flag set when a device is added is interpreted by fw_devlink to mean the > > device has already been initialized and will never probe. This prevents > > fw_devlink from creating device links with the gpio_device as a > > supplier. So, clear the flag before adding the device. ... > > + if (gdev->dev.fwnode && !gdev->dev.fwnode->dev) > > + fwnode_dev_initialized(gdev->dev.fwnode, false); > > Please, do not dereference fwnode from struct device. We have dev_fwnode() > for that. Note, with that fixed you may add my Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko