On Mon 06 Feb 2023 at 13:59, Rob Herring <robh@xxxxxxxxxx> wrote: > On Mon, 06 Feb 2023 16:34:44 +0100, Jerome Brunet wrote: >> Convert the DT binding documentation for the Amlogic tdm formatters to >> schema. >> >> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx> >> --- >> .../sound/amlogic,axg-tdm-formatters.txt | 36 -------- >> .../sound/amlogic,axg-tdm-formatters.yaml | 88 +++++++++++++++++++ >> 2 files changed, 88 insertions(+), 36 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-tdm-formatters.txt >> create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-tdm-formatters.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/sound/amlogic,axg-tdm-formatters.yaml: > Unable to find schema file matching $id: > http://devicetree.org/schemas/sound/component-common.yaml This is a false error because the bot does not have the patch applied by Mark from v1 here [0] [0]: https://lore.kernel.org/all/167543616131.928818.17902040818579023398.b4-ty@xxxxxxxxxx/ > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/amlogic,axg-tdm-formatters.example.dtb: > audio-controller@500: False schema does not allow {'compatible': > ['amlogic,g12a-tdmout'], 'reg': [[1280, 64]], 'resets': [[4294967295, 12]], > 'clocks': [[4294967295, 35], [4294967295, 127], [4294967295, 120], > [4294967295, 134], [4294967295, 134]], 'clock-names': ['pclk', 'sclk', > 'sclk_sel', 'lrclk', 'lrclk_sel'], '$nodename': ['audio-controller@500']} > From schema: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/amlogic,axg-tdm-formatters.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230206153449.596326-3-jbrunet@xxxxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema.
