On Thu, 19 Jan 2023 at 19:40, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 18/01/2023 09:40, Chunyan Zhang wrote:
> > Add basic support for Unisoc's UMS512, with this patch,
> > the board ums512-1h10 can run into console.
> >
[snip]
> > + ap-apb {
>
> Non-unit-address nodes cannot be mixed with unit address ones. Something
> is wrong here.
To make sure I understand correctly, did you mean non-unit-address
nodes shouldn't be the parent of unit-address nodes?
Does that mean the bus node should have a unique base address like:
ap-apb@70000000 {
...
Thanks,
Chunyan
>
> > + compatible = "simple-bus";
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > +
> > + sdio0: sdio@71100000 {
> > + compatible = "sprd,sdhci-r11";
> > + reg = <0 0x71100000 0 0x1000>;
> > + interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> > + clock-names = "sdio", "enable";
> > + clocks = <&ap_clk CLK_SDIO0_2X>,
> > + <&apapb_gate CLK_SDIO0_EB>;
> > + assigned-clocks = <&ap_clk CLK_SDIO0_2X>;
> > + assigned-clock-parents = <&pll1 CLK_RPLL>;
> > + status = "disabled";
> > + };
