Hi Benjamin, > By the way, was the mailing list dropped from cc by mistake ? No, I just wanted to send a remind about the patch to Sakari and Laurent. Now it looks that this thread became more technical, so I am adding cc again. > >> I took a glance already and the driver seems reasonably good but I'm > >> concerned of the interface. How generic is it? I can't say to be an expert > >> on these devices and we don't have any other ToF cameras yet. Is the > >> precision (8 bits) of the control values enough? > > Fairly, that it is an interesting question. > > The frequency modulation defines the maximum range of object detection. > > 1 MHz precision is what we need usually, as the maximum range is from > > 1.5m(100Mhz) till 150(1MHz) meters then. > > Usually, user applications use 60-80MHz(max range is 1.8 - 2.5meters). > > Also, it is possible to have smaller step then 1 MHz, but it is not that practical. > > I am ok switch to Hz and use u32. In that case we will not be limited for generic case. > > > > Benjamin, what precision is better for frequency modulation in your case? > > Good catch, we do require Hz precision for some frequencies we use. > In other systems we use floats expressed as Mhz for this. As Linux only > supports integers, switching it to u32 and express it as Hz is a good idea. Ok, then I'll redo in next version. -- -- BR, Volodymyr Kharuk
