Re: [PATCH 1/3] ASoC: dt-bindings: irondevice,sma1303: Rework binding and add missing properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> > +  sys-clk-id:
> > +    description:
> > +      select the using system clock.
> > +      0 = External Clock 19.2MHz
> > +      1 = External Clock 24.576MHz
> > +      2 = Using PLL in MCLK
> > +      3 = Using PLL in BCLK
> > +    $ref: "/schemas/types.yaml#/definitions/uint32"
> > +    maximum: 3
> > +    default: 3
> 
> We really shouldn't have this as a custom property, we should be using a
> combination of the clock bindings.
> 
> In the driver this would turn into using clk_get() to get the MCLK, then
> we can query the rate with clk_get_rate() and use option 0 or 1 if the
> rate matches, or the PLL otherwise.  If we fail to get MCLK then we can
> fall back to using BCLK.

Okay, I got it.
I'll make it based on what you sent me using other drivers.
Thanks, your feedback.

Best regards,
Kiseok Jo

Attachment: signature.asc
Description: signature.asc


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux