On Fri, Feb 03, 2023 at 04:14:56PM +0100, Krzysztof Kozlowski wrote: > On 03/02/2023 13:50, Sascha Hauer wrote: > > Convert the Rockchip DFI binding to yaml. While at it add the newly > > supported rk3568-dfi to the binding. > > > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. That's what I did. I skipped you and Rob because I know you're wathcing the list anyway. > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > new file mode 100644 > > index 0000000000000..e082a0df7895a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > rockchip,dfi.yaml ok. > > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/devfreq/event/rockchip-dfi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Rockchip DFI > > + > > +maintainers: > > + - Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - rk3399-dfi > > + - rk3568-dfi > > These are not correct compatibles. What's wrong with them? > > > + > > + clocks: > > + maxItems: 1 > > + > > + rockchip,pmu: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the syscon managing the "PMU general register files". > > + > > +required: > > + - compatible > > + - reg > > clocks were required They are no longer, the RK3568 doesn't have a clock. Do I have to add something to make the clock optional on RK3568 only? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
