On Fri 03 Feb 2023 at 09:01, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 02/02/2023 19:36, Jerome Brunet wrote: [...] >> +required: >> + - compatible >> + - reg >> + - "#sound-dai-cells" >> + - clocks >> + - clock-names >> + >> +if: > > Keep in allOf here (need to move ref from top to here) > I'm not sure I get it. As it is, it seems to have the effect I had in mind while trying with dt_bindings_check. What does it do when putting the conditional under the AllOf section ? >> + properties: >> + compatible: >> + contains: >> + enum: >> + - amlogic,g12a-pdm >> + - amlogic,sm1-pdm >> +then: >> + properties: >> + resets: >> + items: >> + - description: Dedicated device reset line > > Define properties in top level properties. > >> + >> + required: >> + - resets >> + >> +unevaluatedProperties: false > > > Best regards, > Krzysztof