On Tue, 31 Jan 2023 14:13:44 +0100, Linus Walleij wrote: > On Tue, Dec 20, 2022 at 1:55 AM Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> wrote: > >> This patch series adds basic pinctrl support for StarFive JH7110 SoC. >> You can simply get or review the patches at the link [1]. >> >> [1]: https://github.com/hal-feng/linux/commits/visionfive2-minimal >> >> Changes since v2: >> - Rebased on tag v6.1. > > Overall this looks OK, the DT bindings does not have any review from > the DT people but I think they had enough time to do that and were > properly CC:ed so not your fault. > > However when I try to apply this to the pinctrl tree it fails, > for example it seems to depend on an entry in MAINTAINERS > which isn't upstream. > > Can you please rebase the patches that are supposed to be > applied to the pinctrl tree (for example normally not patch 1, the DTS > patch) on my "devel" branch: > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel I will drop the patch 1 and rebase the patches on your "devel" branch. I will resend patch 1 after the device tree patches about StarFive JH7110 [1] are merged. [1] https://lore.kernel.org/all/20221220011247.35560-1-hal.feng@xxxxxxxxxxxxxxxx/ Thank you for spending time to review this series. Best regards, Hal > > If you resend this quickly I can apply it pronto.
