On 02/02/2023 15:33, Martin Zaťovič wrote: > GPIO bitbanged Wiegand controller requires definitions of GPIO > lines to be used on top of the common Wiegand properties. Wiegand > utilizes two such lines - D0(low data line) and D1(high data line). Subject: drop second/last, redundant "bindings". The "documentation" prefix is already stating that these are bindings. You already got almost same comment with your v1. > > Signed-off-by: Martin Zaťovič <m.zatovic1@xxxxxxxxx> > --- > .../bindings/wiegand/wiegand-gpio.yaml | 51 +++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml b/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml > new file mode 100644 > index 000000000000..3af0b7e04b3a > --- /dev/null > +++ b/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/wiegand/wiegand-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: GPIO bitbanged Wiegand interface devicetree bindings Drop "devicetree bindings" You already got almost same comment with your v1. > + > +maintainers: > + - Martin Zaťovič <m.zatovic1@xxxxxxxxx> > + > +description: > + This represents the GPIO lines used for bit-banged Wiegand on dedicated GPIO > + lines. > + > +allOf: > + - $ref: "/schemas/wiegand/wiegand-controller.yaml#" Drop quotes > + > +properties: > + compatible: > + const: wiegand-gpio > + > + data-hi-gpios: > + description: GPIO used as Wiegands data-hi line. > + maxItems: 1 > + > + data-lo-gpios: > + description: GPIO used as Wiegands data-lo line. > + maxItems: 1 > + > +required: > + - compatible > + - data-hi-gpios > + - data-lo-gpios > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + wiegand@f00 { Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
