On 02/02/2023 14:50, Vladimir Zapolskiy wrote: > From: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > > Newer Qualcomm chips support newer versions of the qce crypto IP, so add > soc specific compatible strings for qcom-qce instead of using crypto > IP version specific ones. > > Keep the old strings for backward-compatibility, but mark them as > deprecated. > > Cc: Bjorn Andersson <andersson@xxxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Tested-by: Jordan Crouse <jorcrous@xxxxxxxxxx> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx> > --- > .../devicetree/bindings/crypto/qcom-qce.yaml | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > index a159089e8a6a..4e0b63b85267 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > @@ -15,7 +15,22 @@ description: > > properties: > compatible: > - const: qcom,crypto-v5.1 > + oneOf: > + - const: qcom,crypto-v5.1 > + deprecated: true > + description: Kept only for ABI backward compatibility > + - items: Drop items. > + - enum: > + - qcom,ipq4019-qce > + - qcom,ipq6018-qce > + - qcom,ipq8074-qce > + - qcom,msm8996-qce > + - qcom,sdm845-qce > + - qcom,sm8150-qce > + - qcom,sm8250-qce > + - qcom,sm8350-qce > + - qcom,sm8450-qce > + - qcom,sm8550-qce Unfortunately my comments from v6 was not addressed, nor responded to. We already got a public comment from community that we handle Qualcomm bindings in a too loose way. I don't think we should be doing this (so keep ignoring ABI), just for the sanity of cleanup. It's fine to discuss it with me, but since v6 there was no discussion, so let's be clear here - NAK on ABI break. Best regards, Krzysztof
