On 02/02/2023 11:10, Maarten Zanders wrote:
> Add a binding to configure the internal charge pump for lp55xx.
>
> Signed-off-by: Maarten Zanders <maarten.zanders@xxxxxxx>
> ---
>
> Notes:
> v1: implement as bool to disable charge pump
> v2: rewrite to use string configuration, supporting all modes
> v3: simplification by replacing string option by u8 constant,
> removing previous Reviewed-by tags as it's a complete
> rewrite of the patch.
> v4: added notes
>
> .../devicetree/bindings/leds/leds-lp55xx.yaml | 8 ++++++++
> include/dt-bindings/leds/leds-lp55xx.h | 10 ++++++++++
> 2 files changed, 18 insertions(+)
> create mode 100644 include/dt-bindings/leds/leds-lp55xx.h
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> index ae607911f1db..22e63d89d770 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> @@ -66,6 +66,12 @@ properties:
> '#size-cells':
> const: 0
>
> + ti,charge-pump-mode:
> + description:
> + Set the operating mode of the internal charge pump as defined in
> + <dt-bindings/leds/leds-lp55xx.h>. Defaults to auto.
> + $ref: /schemas/types.yaml#/definitions/uint8
> +
> patternProperties:
> '^multi-led@[0-8]$':
> type: object
> @@ -152,6 +158,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/leds/common.h>
> + #include <dt-bindings/leds/leds-lp55xx.h>
>
> i2c {
> #address-cells = <1>;
> @@ -164,6 +171,7 @@ examples:
> reg = <0x32>;
> clock-mode = /bits/ 8 <2>;
> pwr-sel = /bits/ 8 <3>; /* D1~9 connected to VOUT */
> + ti,charge-pump-mode = /bits/ 8 <LP55XX_CP_BYPASS>;
No. V2 was correct. What happened here? You got review for v2, but
suddenly entire patch goes into other direction...
Best regards,
Krzysztof
