Hi Paul, > > >>> +MODULE_LICENSE("GPL"); > > >> > > >> Not GPL v2? When using GPL v2, I got this warning from checkpatch.pl: WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") #2104: FILE: drivers/media/platform/nuvoton/npcm-video.c:1816: +MODULE_LICENSE("GPL v2"); It looks better to keep GPL, do you have any suggestions? Regards, Marvin