On 01/02/2023 16:21, Manuel Traut wrote: > Adds an array of supported volume levels and a default volume level. Adds -> Add > > Signed-off-by: Manuel Traut <manuel.traut@xxxxxx> > --- > .../devicetree/bindings/input/pwm-beeper.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > index 1ebc3a46d934..6599e28ba5e6 100644 > --- a/Documentation/devicetree/bindings/input/pwm-beeper.yaml > +++ b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > @@ -25,6 +25,21 @@ properties: > beeper-hz: > description: bell frequency in Hz > > + volume-levels-bp: > + description: > > + Array of PWM duty cycle values that correspond to > + linear volume levels. These need to be in the range of > + 0 to 5000, while 0 means 0% duty cycle (mute) and 5000 > + means 50% duty cycle (max volume). Is range 0-5000 limitation of the device? If so, this should not be free-form text, but "maximum: 5000" (minimum is 0 anyway). > + Please note that the actual volume of most beepers is > + highly non-linear, which means that low volume levels > + are probably somewhere in the range of 10 to 300 (0.1-3% > + duty cycle). Best regards, Krzysztof
