Re: [PATCH 2/2] PM / devfreq: qcom: Introduce CCI devfreq driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/02/2023 11:32, Dmitry Baryshkov wrote:
On 01/02/2023 10:02, Jun Nie wrote:
Cache Coherent Interconnect (CCI) is used by some Qualcomm SoCs. This
driver is introduced so that its freqency can be adjusted. And regulator
associated with opp table can be also adjusted accordingly which is
shared with cpu cluster.

Signed-off-by: Jun Nie <jun.nie@xxxxxxxxxx>
---
  drivers/devfreq/Kconfig    |   9 +++
  drivers/devfreq/Makefile   |   1 +
  drivers/devfreq/qcom-cci.c | 162 +++++++++++++++++++++++++++++++++++++
  3 files changed, 172 insertions(+)
  create mode 100644 drivers/devfreq/qcom-cci.c

Could you please describe in some additional details what are you trying to achieve? Should the CCI frequency be scaled manually or does it follow the cluster frequency? Do clusters vote on the CCI frequency?

I'm inclined to ask if it is possible to shift this to the cpufreq OPP tables?


Might not be so easy to just append CCI opps to the cluster frequency opps

                cci_cache: qcom,cci {
                        compatible = "qcom,msm8939-cci";
                        clock-names = "devfreq_clk";
                        clocks = <&apcs2>;
                        governor = "cpufreq";
                        operating-points-v2 = <&cci_opp_table>;
                        power-domains = <&cpr>;
                        power-domain-names = "cpr";
                        nvmem-cells = <&cpr_efuse_speedbin_pvs>;
                        nvmem-cell-names = "cpr_efuse_speedbin_pvs";
                };

                devfreq-cpufreq {
                        cci-cpufreq {
                                target-dev = <&cci_cache>;
                                cpu-to-dev-map-0 =
                                        <  200000  200000000 >,
                                        <  345600  200000000 >,
                                        <  400000  200000000 >,
                                        <  533330  297600000 >,
                                        <  800000  297600000 >,
                                        <  960000  297600000 >,
                                        < 1113600  297000000 >,
                                        < 1344000  595200000 >,
                                        < 1459200  595200000 >,
                                        < 1497600  595200000 >,
                                        < 1651200  595200000 >;
                                cpu-to-dev-map-4 =
                                        <  200000 200000000 >,
                                        <  249600 200000000 >,
                                        <  499200 297600000 >,
                                        <  800000 297600000 >,
                                        <  998400 595200000 >,
                                        < 1113600 595200000 >;
                        };
                };

        cci_opp_table: cci-opp-table {
                compatible = "operating-points-v2";

                opp-200000000 {
                        opp-hz = /bits/ 64 <200000000>;
                        opp-supported-hw = <0x3f>;
                        required-opps = <&cpr_opp3>;
                };

                opp-297600000 {
                        opp-hz = /bits/ 64 <297600000>;
                        opp-supported-hw = <0x3f>;
                        required-opps = <&cpr_opp12>;
                };

                opp-400000000-cpr14 {
                        opp-hz = /bits/ 64 <400000000>;
                        opp-supported-hw = <0x1>;
                        required-opps = <&cpr_opp14>;
                };

                opp-400000000-cpr15 {
                        opp-hz = /bits/ 64 <400000000>;
                        opp-supported-hw = <0x3e>;
                        required-opps = <&cpr_opp15>;
                };

                opp-595200000 {
                        opp-hz = /bits/ 64 <595200000>;
                        opp-supported-hw = <0x3f>;
                        required-opps = <&cpr_opp17>;
                };
        };


        cpr_opp_table: cpr-opp-table {
                compatible = "operating-points-v2-qcom-level";

                cpr_opp1: opp1 {
                        opp-hz = /bits/ 64 <200000000>;
                        opp-level = <1>;
                        qcom,opp-fuse-level = <1>;
                };
                cpr_opp2: opp2 {
                        opp-hz = /bits/ 64 <345600000>;
                        opp-level = <2>;
                        qcom,opp-fuse-level = <1>;
                };
                cpr_opp3: opp3 {
                        opp-hz = /bits/ 64 <400000000>;
                        opp-level = <3>;
                        qcom,opp-fuse-level = <1>;
                };
                cpr_opp4: opp4 {
                        opp-hz = /bits/ 64 <422400000>;
                        opp-level = <4>;
                        qcom,opp-fuse-level = <2>;
                };
                cpr_opp5: opp5 {
                        opp-hz = /bits/ 64 <499200000>;
                        opp-level = <5>;
                        qcom,opp-fuse-level = <2>;
                };
                cpr_opp6: opp6 {
                        opp-hz = /bits/ 64 <533330000>;
                        opp-level = <6>;
                        qcom,opp-fuse-level = <2>;
                };
                cpr_opp7: opp7 {
                        opp-hz = /bits/ 64 <652800000>;
                        opp-level = <7>;
                        qcom,opp-fuse-level = <2>;
                };
                cpr_opp8: opp8 {
                        opp-hz = /bits/ 64 <729600000>;
                        opp-level = <8>;
                        qcom,opp-fuse-level = <2>;
                };
                cpr_opp9: opp9 {
                        opp-hz = /bits/ 64 <800000000>;
                        opp-level = <9>;
                        qcom,opp-fuse-level = <2>;
                };
                cpr_opp10: opp10 {
                        opp-hz = /bits/ 64 <806400000>;
                        opp-level = <10>;
                        qcom,opp-fuse-level = <2>;
                };
                cpr_opp11: opp11 {
                        opp-hz = /bits/ 64 <883200000>;
                        opp-level = <11>;
                        qcom,opp-fuse-level = <2>;
                };
                cpr_opp12: opp12 {
                        opp-hz = /bits/ 64 <960000000>;
                        opp-level = <12>;
                        qcom,opp-fuse-level = <2>;
                };
        };

---
bod



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux