Hi Conor, Thanks for your reply. Conor Dooley <conor@xxxxxxxxxx> 於 2023年2月1日 週三 上午2:32寫道： > > Hey Nylon, > > On Mon, Jan 30, 2023 at 05:32:28PM +0800, Nylon Chen wrote: > > This removes the active-low properties of the PWM-controlled LEDs in > > the HiFive Unmatched device tree. > > > > The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1]. > > > > [0]: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf > > [1]: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf > > Ideally these would be: > Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf [0] > so that they integrate nice with the git trailers mechanism. > If you resend, please update them to regular link tags. > I will fix this issue. > I checked out the circuits last time around and agreed that they should > not be active-low. > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > I expect that both patches will go through the PWM tree together, so: > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Thanks, > Conor. > Thanks a lot. > > > > Signed-off-by: Nylon Chen <nylon.chen@xxxxxxxxxx> > > --- > > arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 4 ---- > > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ---- > > 2 files changed, 8 deletions(-) > > > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > index 900a50526d77..7a9f336a391c 100644 > > --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > @@ -50,7 +50,6 @@ led-controller { > > > > led-d1 { > > pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color = <LED_COLOR_ID_GREEN>; > > max-brightness = <255>; > > label = "d1"; > > @@ -58,7 +57,6 @@ led-d1 { > > > > led-d2 { > > pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color = <LED_COLOR_ID_GREEN>; > > max-brightness = <255>; > > label = "d2"; > > @@ -66,7 +64,6 @@ led-d2 { > > > > led-d3 { > > pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color = <LED_COLOR_ID_GREEN>; > > max-brightness = <255>; > > label = "d3"; > > @@ -74,7 +71,6 @@ led-d3 { > > > > led-d4 { > > pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color = <LED_COLOR_ID_GREEN>; > > max-brightness = <255>; > > label = "d4"; > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > index 07387f9c135c..11f08a545ee6 100644 > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > @@ -52,7 +52,6 @@ led-controller-1 { > > > > led-d12 { > > pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color = <LED_COLOR_ID_GREEN>; > > max-brightness = <255>; > > label = "d12"; > > @@ -69,19 +68,16 @@ multi-led { > > > > led-red { > > pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color = <LED_COLOR_ID_RED>; > > }; > > > > led-green { > > pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color = <LED_COLOR_ID_GREEN>; > > }; > > > > led-blue { > > pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color = <LED_COLOR_ID_BLUE>; > > }; > > }; > > -- > > 2.36.1 > >
