On Tue, Jan 31, 2023 at 07:51:20PM +0100, Krzysztof Kozlowski wrote: > On 31/01/2023 19:10, Saurabh Sengar wrote: > > Add dt-bindings for Hyper-V VMBus > > > > Signed-off-by: Saurabh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx> > > --- > > .../bindings/hypervisor/msft,vmbus.yaml | 50 +++++++++++++++++++ > > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > > MAINTAINERS | 1 + > > 3 files changed, 53 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hypervisor/msft,vmbus.yaml > > > > diff --git a/Documentation/devicetree/bindings/hypervisor/msft,vmbus.yaml b/Documentation/devicetree/bindings/hypervisor/msft,vmbus.yaml > > new file mode 100644 > > index 000000000000..8f50d6097c48 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hypervisor/msft,vmbus.yaml > > @@ -0,0 +1,50 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/hypervisor/msft,vmbus.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Microsoft Hyper-V VMBus device tree bindings > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > > Thank you. > > (other places as well...) Hi Krzysztof, Thank you for the review. Sorry I missed this, will fix in V3. The patches have gone significant modification, and I have thought I have fixed all the comments you have provided hence didnt send the follow up discussion. Apparently, I may have missed few will look again and fix in next version. Regards, Saurabh > > Best regards, > Krzysztof
