Re: [PATCH 1/1] dt-bindings: iio: adc: add missing vref-supply

[Marco Felsch <m.felsch@xxxxxxxxxxxxxx>]

Hi Alexander,

On 23-01-31, Alexander Stein wrote:
> Although this property is used right now for IIO_CHAN_INFO_SCALE,
> this ADC has two internal reference voltages, which the driver currently
> doesn't make use of.
> 
> Fixes: db73419d8c06 ("dt-bindings: iio: adc: Add binding documentation for NXP IMX8QXP ADC")
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml          | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml
> index 63369ba388e4..879768af0303 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml
> @@ -39,6 +39,9 @@ properties:
>    power-domains:
>      maxItems: 1
>  
> +  vref-supply:
> +    description: External ADC reference voltage supply on VREFH pad.

Please add it to the list of required properties, we can remove it as
soon as the driver has support for the internal reference voltages.

Regards,
  Marco

> +
>    "#io-channel-cells":
>      const: 1
>  
> @@ -72,6 +75,7 @@ examples:
>              assigned-clocks = <&clk IMX_SC_R_ADC_0>;
>              assigned-clock-rates = <24000000>;
>              power-domains = <&pd IMX_SC_R_ADC_0>;
> +            vref-supply = <&reg_1v8>;
>              #io-channel-cells = <1>;
>          };
>      };
> -- 
> 2.34.1
> 
> 
>