On 2023/1/31 8:38, Stephen Boyd wrote: > Quoting Xingyu Wu (2023-01-19 18:44:40) >> diff --git a/drivers/clk/starfive/clk-starfive-jh7110-isp.c b/drivers/clk/starfive/clk-starfive-jh7110-isp.c >> new file mode 100644 >> index 000000000000..f9fc94b4c6f8 >> --- /dev/null >> +++ b/drivers/clk/starfive/clk-starfive-jh7110-isp.c >> @@ -0,0 +1,218 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * StarFive JH7110 Image-Signal-Process Clock Driver > [...] >> + >> +static int jh7110_isp_top_crg_enable(struct isp_top_crg *top) >> +{ >> + int ret; >> + >> + ret = clk_bulk_prepare_enable(top->top_clks_num, top->top_clks); >> + if (ret) >> + return ret; >> + >> + return reset_control_deassert(top->top_rsts); >> +} > > This needs to be undone on driver remove. Will add in next patch. Best regards, Xingyu Wu