Hi Andrew, On 2023/1/30 22:03, Andrew Lunn wrote: > On Mon, Jan 30, 2023 at 02:35:35PM +0800, Frank Sae wrote: >> Add a YAML binding document for the Motorcom yt8xxx Ethernet phy driver. >> >> Signed-off-by: Frank Sae <Frank.Sae@xxxxxxxxxxxxxx> >> --- >> .../bindings/net/motorcomm,yt8xxx.yaml | 102 ++++++++++++++++++ >> .../devicetree/bindings/vendor-prefixes.yaml | 2 + >> MAINTAINERS | 1 + >> 3 files changed, 105 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> new file mode 100644 >> index 000000000000..8527576c15b3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> @@ -0,0 +1,102 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/motorcomm,yt8xxx.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: MotorComm yt8xxx Ethernet PHY >> + >> +maintainers: >> + - frank sae <frank.sae@xxxxxxxxxxxxxx> >> + >> +allOf: >> + - $ref: ethernet-phy.yaml# >> + >> +properties: >> + rx-internal-delay-ps: >> + description: | >> + RGMII RX Clock Delay used only when PHY operates in RGMII mode with >> + internal delay (phy-mode is 'rgmii-id' or 'rgmii-rxid') in pico-seconds. >> + enum: [ 0, 150, 300, 450, 600, 750, 900, 1050, 1200, 1350, 1500, 1650, >> + 1800, 1900, 1950, 2050, 2100, 2200, 2250, 2350, 2500, 2650, 2800, >> + 2950, 3100, 3250, 3400, 3550, 3700, 3850, 4000, 4150 ] >> + default: 1950 > > Ah! There has been a misunderstand. Yes, this changes does make sense, but > >> + >> + tx-internal-delay-ps: >> + description: | >> + RGMII TX Clock Delay used only when PHY operates in RGMII mode with >> + internal delay (phy-mode is 'rgmii-id' or 'rgmii-txid') in pico-seconds. >> + enum: [ 0, 150, 300, 450, 600, 750, 900, 1050, 1200, 1350, 1500, 1650, 1800, >> + 1950, 2100, 2250 ] >> + default: 150 > > ... i was actually trying to say this 150 is odd. Why is this not > 1950? Tx-delay is usually adjusted by the mac (~ 2ns). So here is only fine-turn for the tx-delay. > > Andrew
