On Sun, Jan 29, 2023 at 03:51:29PM -0600, Steev Klimaszewski wrote: > From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> You should also add your Signed-off-by. Also the title of the patch should be updated to say define uart2 instead of enable BT. > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 122afa03bb40..2d98687fb1ea 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1244,6 +1244,20 @@ spi3: spi@98c000 { > status = "disabled"; > }; > > + uart2: serial@988000 { This node needs to go after spi2 instead of spi3. Everything else looks good to me. Brian