On 30/01/2023 11:40, Balsam CHIHI wrote:
Hi Krzysztof,
Thank you for the feedback.
On Sat, Jan 28, 2023 at 11:48 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
On 26/01/2023 17:10, bchihi@xxxxxxxxxxxx wrote:
From: Balsam CHIHI <bchihi@xxxxxxxxxxxx>
Add LVTS thermal controllers dt-binding definition for mt8195.
Subject: drop second/last, redundant "dt-binding definition". The
"dt-bindings" prefix is already stating that these are bindings.
fixed.
The patch title has been fixed as you suggested :
"dt-bindings: thermal: mediatek: Add LVTS thermal controllers"
Plus two comments at the end.
Signed-off-by: Balsam CHIHI <bchihi@xxxxxxxxxxxx>
---
Changelog:
v12:
- Fixed subject prefix
- Fixed licences GPL-2.0+ to GPL-2.0
- Added dual licenses
+ };
diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h
new file mode 100644
index 000000000000..902d5b1e4f43
--- /dev/null
+++ b/include/dt-bindings/thermal/mediatek-lvts.h
Same filename as bindings.
fixed.
rename :
include/dt-bindings/thermal/mediatek-lvts.h =>
include/dt-bindings/thermal/mediatek-lvts-thermal.h
I think it should be
include/dt-bindings/thermal/mediatek,lvts-thermal.yaml
Regards,
Matthias
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: (GPL-2.0 or MIT) */
Although this is correct, any reason why not using exactly the same
license as bindings?
fixed.
both files are now using the same license :
"SPDX-License-Identifier: (GPL-2.0 or MIT)"
+/*
+ * Copyright (c) 2023 MediaTek Inc.
+ * Author: Balsam CHIHI <bchihi@xxxxxxxxxxxx>
+ */
Best regards,
Krzysztof
I'll send the changes soon.
Best regards,
Balsam
