On 2023/1/26 10:35, Stephen Boyd wrote: > Quoting Xingyu Wu (2023-01-19 18:44:40) >> diff --git a/drivers/clk/starfive/clk-starfive-jh7110-isp.c b/drivers/clk/starfive/clk-starfive-jh7110-isp.c >> new file mode 100644 >> index 000000000000..f9fc94b4c6f8 >> --- /dev/null >> +++ b/drivers/clk/starfive/clk-starfive-jh7110-isp.c >> @@ -0,0 +1,218 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * StarFive JH7110 Image-Signal-Process Clock Driver >> + * >> + * Copyright (C) 2022 StarFive Technology Co., Ltd. >> + */ >> + >> +#include <linux/clk.h> > > Same include comment. This signals this is a clk consumer, which it > isn't? This driver need to use 'clk_bulk_data' struct and some functions like 'devm_clk_bulk_get()' and 'clk_bulk_prepare_enable()' from this include. Best regards, Xingyu Wu
