Re: [PATCH] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 28, 2023 at 11:13 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 27/01/2023 22:22, Bartosz Golaszewski wrote:
> > On Fri, 27 Jan 2023 at 20:56, Krzysztof Kozlowski
> > <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> >>
> >> On 27/01/2023 20:21, Bartosz Golaszewski wrote:
> >>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >>>
> >>> Add a compatible for the sa8775p platform's Secure Channel Manager
> >>> firmware interface.
> >>>
> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >>> ---
> >>>  Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>
> >> If you send bindings separately from DTS (which is fine), please provide
> >> the link to the user - either DTS or driver for this compatible. Driver
> >> does not use it, thus to the DTS.
> >>
> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> >>
> >
> > Can you specify what kind of link you're expecting? I'm looking at
> > previous commits for this file and not seeing anything. There's no
> > upstream user of this compatible in any DTS yet.
>
>
> I expect lore link to the patchset you sent using this binding, so we
> can verify whether you used it correctly or not. If people were testing
> their DTS against bindings they write, this would not be needed.
> Unfortunately people do not do that...
>

Touché. I am making sure v2 passes dtbs_check though. :)

v1 didn't have this compatible and used the fallback directly, hence
this patch being sent before v2. There's no link yet, as I'm still
polishing the dts for sa8775p-ride. Will remember to add one in the
future.

Bart




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux