> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Saturday, January 28, 2023 2:57 AM > To: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Alim Akhtar > <alim.akhtar@xxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Cc: replicant@xxxxxxxxxx; phone-devel@xxxxxxxxxxxxxxx; > ~postmarketos/upstreaming@xxxxxxxxxxx; Martin Jücker > <martin.juecker@xxxxxxxxx>; Henrik Grimler <henrik@xxxxxxxxxx>; Sam > Protsenko <semen.protsenko@xxxxxxxxxx>; Chanho Park > <chanho61.park@xxxxxxxxxxx>; Marek Szyprowski > <m.szyprowski@xxxxxxxxxxx>; Chanwoo Choi > <cw00.choi@xxxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> > Subject: [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3 > node wrapper in Exynos7 > > Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node > which do not have unit address. Therefore usethe address space of child > device (actual DWC3 Controller) as the wrapper's address to > fix: > > exynos7-espresso.dtb: soc@0: usb: {'compatible': ['samsung,exynos7- > dwusb3'], ... > should not be valid under {'type': 'object'} > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> Tested on exynos7-espresso and xHCI driver still gets probed, so Tested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > > Changes since v1: > 1. New patch > --- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi > b/arch/arm64/boot/dts/exynos/exynos7.dtsi > index 82fee1b7caab..b1fa68835b09 100644 > --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi > @@ -690,7 +690,7 @@ usbdrd_phy: phy@15500000 { > #phy-cells = <1>; > }; > > - usbdrd: usb { > + usbdrd: usb@15400000 { > compatible = "samsung,exynos7-dwusb3"; > clocks = <&clock_fsys0 ACLK_USBDRD300>, > <&clock_fsys0 SCLK_USBDRD300_SUSPENDCLK>, > @@ -699,11 +699,11 @@ usbdrd: usb { > "usbdrd30_axius_clk"; > #address-cells = <1>; > #size-cells = <1>; > - ranges; > + ranges = <0x0 0x15400000 0x10000>; > > - usb@15400000 { > + usb@0 { > compatible = "snps,dwc3"; > - reg = <0x15400000 0x10000>; > + reg = <0x0 0x10000>; > interrupts = <GIC_SPI 223 > IRQ_TYPE_LEVEL_HIGH>; > phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>; > phy-names = "usb2-phy", "usb3-phy"; > -- > 2.34.1