On Fri 27 Jan 2023 at 14:02, Heiner Kallweit <hkallweit1@xxxxxxxxx> wrote: > On 27.01.2023 08:59, Neil Armstrong wrote: >> Hi, >> >> On 26/01/2023 15:03, Heiner Kallweit wrote: >>> The usage of edge-triggered interrupts lead to lost interrupts under load, >>> see [0]. This was confirmed to be fixed by using level-triggered >>> interrupts. >>> The report was about SDIO. However, as the host controller is the same >>> for SD and MMC, apply the change to all mmc controller instances. >> >> Thanks, I applied it in for-next so it runs on the CI tests. >> >>> >>> [0] https://www.spinics.net/lists/linux-mmc/msg73991.html >>> >>> Fixes: 1499218c80c9 ("arm64: dts: move common G12A & G12B modes to meson-g12-common.dtsi") >> >> I think we should find a better Fixes or perhaps split in 3 so it targets the >> right commit adding the nodes for each family. >> > This would be the cleanest option, right. Practically it shouldn't make > much of a difference. The chosen commit is from 2019, SDIO interrupt > support has been added just recently, and regarding MMC/SD it seems no > problems caused by edge-triggered interrupts are known. ... Well, I wonder is this might be linked to instabilities seen with very high speed mode (such as SDR104) and DDR modes. We have seen quite a lot of those over the years. In any case, if it helps stabilize the MMC on amlogic, it would be great if it can be picked up by stable. > >> If the test doesn't report any breakage, I'll probably ask you that. >> > Sure. > >> Neil >> > Heiner
