On Thu, Jan 26, 2023, at 19:14, Leon Romanovsky wrote: > On Thu, Jan 26, 2023 at 02:54:12PM +0100, Arnd Bergmann wrote: >> >> @@ -139,6 +139,12 @@ MODULE_LICENSE("GPL"); >> #define W5500_RX_MEM_START 0x30000 >> #define W5500_RX_MEM_SIZE 0x04000 >> >> +#ifndef CONFIG_WIZNET_BUS_SHIFT >> +#define CONFIG_WIZNET_BUS_SHIFT 0 >> +#endif > > I don't see any define of CONFIG_WIZNET_BUS_SHIFT in the code, so it looks > like it always zero and can be removed. Good catch! Evidently the original idea was that this would be set to a machine specific value through Kconfig. I've renamed the constant, removed the #ifdef and explained it in the changelog text now. Arnd