On 1/25/23 18:48, Shawn Guo wrote: > On Thu, Dec 29, 2022 at 07:01:37PM -0500, Sean Anderson wrote: >> This adds bindings for the SerDes devices. They are disabled by default >> to prevent any breakage on existing boards. >> >> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx> >> --- >> >> (no changes since v4) >> >> Changes in v4: >> - Convert to new bindings >> >> Changes in v3: >> - New >> >> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi >> index 260d045dbd9a..ecf9d830e36f 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi >> @@ -238,6 +238,24 @@ reset: syscon@1e60000 { >> reg = <0x0 0x1e60000 0x0 0x10000>; >> }; >> >> + serdes1: serdes@1ea0000 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + #clock-cells = <1>; >> + compatible = "fsl,ls1088a-serdes", "fsl,lynx-10g"; >> + reg = <0x0 0x1ea0000 0x0 0x2000>; > > Can we start the properties with compatible (and reg) like most of other > device nodes? Sure. --Sean >> + status = "disabled"; >> + }; >> + >> + serdes2: serdes@1eb0000 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + #clock-cells = <1>; >> + compatible = "fsl,ls1088a-serdes", "fsl,lynx-10g"; >> + reg = <0x0 0x1eb0000 0x0 0x2000>; >> + status = "disabled"; >> + }; >> + >> isc: syscon@1f70000 { >> compatible = "fsl,ls1088a-isc", "syscon"; >> reg = <0x0 0x1f70000 0x0 0x10000>; >> -- >> 2.35.1.1320.gc452695387.dirty >>