On Thu, Jan 26, 2023 at 4:23 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 26/01/2023 14:50, Rick Wertenbroek wrote: > > Added missing PCIe endpoint controller entry in the device tree. This > > entry is documented in : > > Documentation/devicetree/bindings/pci/rockchip-pcie-ep.txt > > There is no such file Sorry but the file exists see : https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/Documentation/devicetree/bindings/pci/rockchip-pcie-ep.txt?h=v6.0.19 It also exists in 6.1 : https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/Documentation/devicetree/bindings/pci/rockchip-pcie-ep.txt?h=linux-6.1.y > > > The status is disabled by default, so it will not be loaded unless > > explicitly chosen to. > > Use subject prefixes matching the subsystem (which you can get for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching). > Sorry about this, you are right, I'll fix it for the next iteration. Thank you > > > > Signed-off-by: Rick Wertenbroek <rick.wertenbroek@xxxxxxxxx> > > --- > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 25 ++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > index 9d5b0e8c9..5f7251118 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > > @@ -265,6 +265,31 @@ pcie0_intc: interrupt-controller { > > }; > > }; > > > > + pcie0_ep: pcie-ep@f8000000 { > > + compatible = "rockchip,rk3399-pcie-ep"; > > reg is usually second property... > > + #address-cells = <3>; > > + #size-cells = <2>; > Best regards, > Krzysztof >