On 26/01/2023 11:17, Niall Leonard via B4 Submission Endpoint wrote: > From: Niall Leonard <nl250060@xxxxxxx> Subject: missing "wd,mbl-gpio:" prefix. Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > > Added optional "no-input" property Missing full stop. > > Signed-off-by: Niall Leonard <nl250060@xxxxxxx> > --- > Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt b/Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt > index 038c3a6a1f4d..9405f9dad522 100644 > --- a/Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt > +++ b/Documentation/devicetree/bindings/gpio/wd,mbl-gpio.txt > @@ -18,6 +18,7 @@ Required properties: > > Optional properties: > - no-output: GPIOs are read-only. > + - no-input: GPIOs are write-only. Read is via a shadow register. Why this property is needed? Why driver cannot always use shadow register? Anyway, please convert the bindings to DT schema first (see writing-schema and example-schema). Documentation/devicetree/bindings/writing-schema.rst Best regards, Krzysztof
