Hi Chris, Am Freitag, 7. November 2014, 14:48:20 schrieb Kevin Hilman: > Chris Zhong <zyw@xxxxxxxxxxxxxx> writes: > > RK3288 can shut down the cpu, gpu and other device controllers in suspend, > > and it will pull the GLOBAL_PWROFF pin to high in the final stage of the > > process of suspend, pull the pin to low again when resume. > > The cover letter still doesn't state what this series applies to, or > what its dependencies are for testing, even though it was requested in > earlier reviews[1]. I discovered (again) by trial and error it applies > to current linux-next. I also discovered (as was earlier discussed[2]) > that it still does not resume using current upstream code, and those > dependencies are not described here either. These are the kinds of > things that are crucial in a cover letter in order to help reviewers and > testers not have to spend time digging through the archives trying to > remember from the previous round of reviews. > > Please, please list the out-of-tree dependencies, and how to test, > including how you tested it, and on what hardware. I'll second what Kevin said. I guess the regulator suspend handling [0] is one of the requirements, but I'd think there is more. And while Doug had a quite long list of suspend-related patches in his try, for now we'll need the minimal set to enable this series to sucessfully wake the system again after going to suspend. Heiko [0] https://git.kernel.org/cgit/linux/kernel/git/broonie/regulator.git/log/?h=topic/suspend -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
