On Wed, 2023-01-25 at 14:56 +0100, Marek Vasut wrote: > On 1/25/23 07:40, Liu Ying wrote: > > A valid bridge is already found in lcdif_attach_bridge() and set > > to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop > > the unnecessary NULL pointer check in KMS stage. > > Is it possible that a panel (instead of a bridge) be attached to > LCDIFv3 > e.g. in case of iMXRT ? According to IMXRT1160 and IMXRT1170 reference manuals, it looks like LCDIFv2(similar to LCDIFv3, but not the same) may connect to a parallel display panel through a mux(either eLCDIF or LCDIFv2). That mux could be a bridge. But, it doesn't matter, because devm_drm_of_get_bridge() may create a panel bridge if a panel is connected directly(See kerneldoc of devm_drm_of_get_bridge()). Regards, Liu Ying > > > Signed-off-by: Liu Ying <victor.liu@xxxxxxx> > > --- > > v1->v2: > > * Split from patch 2/2 in v1. (Marek, Alexander) > > Much appreciated, thanks. > > [...]
