Re: [PATCH 2/2] arm64: dts: qcom: sa8540p-ride: Document i2c busses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 1/25/2023 12:53 AM, Andrew Halaney wrote:
It isn't obvious in the current devicetree what is connected. Go ahead
and document what's on the other end.

Signed-off-by: Andrew Halaney <ahalaney@xxxxxxxxxx>
---

Not sure if this sort of patch is actually welcomed or not but I went
through this exercise (for the prior patch) and thought it might be
useful to document.

Shazad, this also highlights (unless I misread things) that i2c12 has no
use for us, right? If agreed I can remove it but sorting through the
lore links that provided all this it seems like at the time it was
desired to be added.


Andrew, i2c12 has GPU PWR ctl use case, so let's keep it enabled.

-Shazad

Thanks,
Andrew

  arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
index cb9fbdeb5a9e..3478ab91fe73 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
@@ -317,6 +317,7 @@ &xo_board_clk {
&tlmm {
  	i2c0_default: i2c0-default-state {
+		/* To USB7002T-I/KDXVA0 USB hub (SIP1 only) */
  		pins = "gpio135", "gpio136";
  		function = "qup0";
  		drive-strength = <2>;
@@ -324,6 +325,7 @@ i2c0_default: i2c0-default-state {
  	};
i2c1_default: i2c1-default-state {
+		/* To PM40028B-F3EI PCIe switch */
  		pins = "gpio158", "gpio159";
  		function = "qup1";
  		drive-strength = <2>;
@@ -331,6 +333,7 @@ i2c1_default: i2c1-default-state {
  	};
i2c12_default: i2c12-default-state {
+		/* Not connected */
  		pins = "gpio0", "gpio1";
  		function = "qup12";
  		drive-strength = <2>;
@@ -338,6 +341,7 @@ i2c12_default: i2c12-default-state {
  	};
i2c15_default: i2c15-default-state {
+		/* To display connector (SIP1 only) */
  		pins = "gpio36", "gpio37";
  		function = "qup15";
  		drive-strength = <2>;
@@ -345,6 +349,7 @@ i2c15_default: i2c15-default-state {
  	};
i2c18_default: i2c18-default-state {
+		/* To ASM330LHH IMU (SIP1 only) */
  		pins = "gpio66", "gpio67";
  		function = "qup18";
  		drive-strength = <2>;



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux