On 24/01/2023 14:53, Jianhua Lu wrote: > Add support for Xiaomi Mi Pad 5 Pro, codename is xiaomi-elish. > > This commit brings support for: > * ADSP/CDSP/SLPI/VENUS > * Backlight > * Battery fuel gauge > * Framebuffer > * PCIe0 > * USB2.0 > > Note backlight driver (ktz8866) is waitting for upstreaming[1]. > [1] https://lore.kernel.org/linux-leds/20230120155018.15376-1-lujianhua000@xxxxxxxxx > > Signed-off-by: Jianhua Lu <lujianhua000@xxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/sm8250-xiaomi-elish.dts | 594 ++++++++++++++++++ > 2 files changed, 595 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index b0423ca3e79f..769cee2b450f 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -184,6 +184,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8250-hdk.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8250-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx203.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8250-sony-xperia-edo-pdx206.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sm8250-xiaomi-elish.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8350-hdk.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8350-microsoft-surface-duo2.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8350-mtp.dtb > diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish.dts > new file mode 100644 > index 000000000000..99ae6668e516 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish.dts > @@ -0,0 +1,594 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2022, 2023 Jianhua Lu <lujianhua000@xxxxxxxxx> > + */ > + > +/dts-v1/; > + > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> > +#include "sm8250.dtsi" > +#include "pm8150.dtsi" > +#include "pm8150b.dtsi" > +#include "pm8150l.dtsi" > +#include "pm8009.dtsi" > + > +/* > + * Delete following upstream (sm8250.dtsi) reserved > + * memory mappings which are different in this device. > + */ > +/delete-node/ &xbl_aop_mem; > +/delete-node/ &slpi_mem; > +/delete-node/ &adsp_mem; > +/delete-node/ &spss_mem; > +/delete-node/ &cdsp_secure_heap; > + > +/ { > + model = "Xiaomi Mi Pad 5 Pro"; > + compatible = "xiaomi,elish", "qcom,sm8250"; > + classis-type = "tablet"; > + > + /* required for bootloader to select correct board */ > + qcom,msm-id = <356 0x20001>; /* SM8250 v2.1 */ > + qcom,board-id = <0x10008 0>; > + > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + framebuffer: framebuffer@9c000000 { > + compatible = "simple-framebuffer"; > + reg = <0 0x9c000000 0 0x2300000>; > + width = <1600>; > + height = <2560>; > + stride = <(1600 * 4)>; > + format = "a8r8g8b8"; > + }; > + }; > + > + gpio_keys: gpio-keys { > + compatible = "gpio-keys"; > + > + vol-up { Missing generic prefix. Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + label = "Volume Up"; > + gpios = <&pm8150_gpios 6 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_VOLUMEUP>; > + debounce-interval = <15>; > + linux,can-disable; > + gpio-key,wakeup; > + }; > + }; > + > + bl_vddpos_5p5: bl-vddpos-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "bl_vddpos_5p5"; > + regulator-min-microvolt = <5500000>; > + regulator-max-microvolt = <5500000>; > + regulator-enable-ramp-delay = <233>; > + gpio = <&tlmm 130 0>; Use defines for flags. > + enable-active-high; > + regulator-boot-on; > + }; > + > + bl_vddneg_5p5: bl-vddneg-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "bl_vddneg_5p5"; > + regulator-min-microvolt = <5500000>; > + regulator-max-microvolt = <5500000>; > + regulator-enable-ramp-delay = <233>; > + gpio = <&tlmm 131 0>; Use defines for flags. > + enable-active-high; > + regulator-boot-on; > + }; > + > + vph_pwr: vph-pwr-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vph_pwr"; > + regulator-min-microvolt = <3700000>; > + regulator-max-microvolt = <3700000>; > + }; > + (...) > + > +&cdsp { > + firmware-name = "qcom/sm8250/xiaomi/elish/cdsp.mbn"; > + status = "okay"; > +}; > + > +&gpi_dma0 { > + status = "okay"; > +}; > + > +&gpi_dma1 { > + status = "okay"; > +}; > + > +&gpi_dma2 { > + status = "okay"; > +}; > + > +&i2c0 { > + clock-frequency = <400000>; > + status = "okay"; > + > + battery_fg@55 { No underscores in node names. Generic node names, so just fuel-gauge > + compatible = "ti,bq27z561"; > + reg = <0x55>; > + monitored-battery = <&battery_r>; > + }; > +}; > + > +&i2c11 { > + clock-frequency = <400000>; > + status = "okay"; > + > + backlight: backlight@11 { > + compatible = "kinetic,ktz8866"; > + reg = <0x11>; > + vddpos-supply = <&bl_vddpos_5p5>; > + vddneg-supply = <&bl_vddneg_5p5>; > + enable-gpios = <&tlmm 139 GPIO_ACTIVE_HIGH>; > + current-num-sinks = <5>; > + kinetic,current-ramp-delay-ms = <128>; > + kinetic,led-enable-ramp-delay-ms = <1>; > + kinetic,enable-lcd-bias; > + }; > +}; > + > +&i2c13 { > + clock-frequency = <400000>; > + status = "okay"; > + > + battery_fg@55 { Same problem > + compatible = "ti,bq27z561"; > + reg = <0x55>; > + monitored-battery = <&battery_l>; > + }; > +}; Best regards, Krzysztof
