Re: [PATCH v5 3/3] i2c: gpio: support write-only sda/scl w/o pull-up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 18, 2023 at 10:55:12PM +0100, Heiner Kallweit wrote:
> There are slave devices that understand I2C but have read-only SDA and
> SCL. Examples are FD650 7-segment LED controller and its derivatives.
> Typical board designs don't even have a pull-up for both pins.
> Handle the new attributes for write-only SDA and missing pull-up on
> SDA/SCL.
> 
> For either pin the open-drain and has-no-pullup properties are
> mutually-exclusive, what is documented in the DT property documentation.
> We don't add an extra warning here because the open-drain properties
> are marked deprecated anyway.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>

Applied to for-next, thanks!

> +	pdata->sda_is_output_only =
> +		of_property_read_bool(np, "i2c-gpio,sda-output-only");
> +	pdata->sda_has_no_pullup =
> +		of_property_read_bool(np, "i2c-gpio,sda-has-no-pullup");
> +	pdata->scl_has_no_pullup =
> +		of_property_read_bool(np, "i2c-gpio,scl-has-no-pullup");

I converted these to device_property_read_bool() because of 7b6e9dc7e42d
("i2c: gpio: Add support on ACPI-based system") which is in my for-next.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux