On Sat, Jan 21, 2023 at 12:40:12AM +0100, Johan Jonker wrote:
>
>
> On 1/20/23 21:30, Rob Herring wrote:
> > On Wed, Jan 18, 2023 at 3:05 PM Johan Jonker <jbx6244@xxxxxxxxx> wrote:
> >>
> >> Hi,
> >>
> >> Some alignment at the examples and the unknown extcon property.
> >>
> >> usb@fe800000: 'extcon' does not match any of the regexes
> >
> > Does that go in the wrapper or dwc3 node?:
> >
> > arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dtb: usb@fe800000:
> > usb@fe800000: Unevaluated properties are not allowed ('extcon' was
> > unexpected)
> > From schema:
> > /home/rob/proj/linux-dt/Documentation/devicetree/bindings/usb/rockchip,rk3399-dwc3.yaml
> >
>
>
> > That's the dwc3 node, but the majority are in the wrapper node, so I'm
> > going with the majority and leaving this one.
>
> In wrapper code for rk33899 in dwc3-of-simple.c I don't see no extcon activity I think.
So all the other cases are just a stray property and the above one is
correct.
'extcon' should be replaced in favor of a connector node, so if not
used, it should be able to be removed. Though maybe BSD or something
else cares.
> In core there's recently made some changes:
> https://github.com/torvalds/linux/blame/master/drivers/usb/dwc3/core.c#L1710
>
> usb: dwc3: Don't switch OTG -> peripheral if extcon is present
> https://lore.kernel.org/all/20221017233510.53336-1-andriy.shevchenko@xxxxxxxxxxxxxxx/
>
> Binding status update for that is unknown for me.
> Do whatever suites you best.
I'm going to leave it as-is for now.
Rob
