On 23/01/2023 12:49, Stephan Gerhold wrote:
It's only required though because you forgot to drop the DT schema patch
(3/4) when I suggested half a year ago that you make the MSM8939
cpufreq-qcom-nvmem changes together with the CPR stack [1]. :/
Didn't forget, tested that and as I recall there are side-effects
removing 8939 from drivers/cpufreq/cpufreq-dt-platdev.c - not all
processors were booted.
Anyway, it looks like qcom-cpufreq-nvmem.yaml requiring "cpr" power
domain unconditionally is a mistake anyway for multiple platforms.
[2] was recently submitted to fix this so that patch should allow you to
drop the dummy nodes. 😄
[1]:https://lore.kernel.org/linux-arm-msm/Ysf8VRaXdGg+8Ev3@xxxxxxxxxxx/
[2]:https://lore.kernel.org/linux-arm-msm/20230122174548.13758-1-ansuelsmth@xxxxxxxxx/
8939 _is_ a CPR device, I think qcs404 comes from msm893x IP.
To me it makes more sense to stub CPR in the DTS than to, wrongly
declare the 8939 a non-CPR device.
---
bod
