Hi Krzysztof, On Fri, Jan 20, 2023 at 8:42 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 09/11/2022 15:46, Geert Uytterhoeven wrote: > > Add the missing trigger patterns for Bluetooth and WLAN activity, which > > are already in active use. > > > > While at it, move the mmc pattern comment where it belongs, and restore > > alphabetical sort order. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed: > > 'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > > 'hci0-power' does not match '^mmc[0-9]+$' > > From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml > > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed: > > 'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern'] > > 'phy0tx' does not match '^mmc[0-9]+$' > > From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml > > This patch got lost... Rob, Lee or Pavel, can you pick it up? > > It's with Rob's approval: > https://lore.kernel.org/all/166861772609.231295.14812410099261417331.robh@xxxxxxxxxx/ If it is going to be applied via bluetooth-next make sure to resend it since last time our CI was not able to apply it thus why we didn't apply it in the first place. > > > --- > > Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml > > index f5c57a580078ea23..d34bb58c00371402 100644 > > --- a/Documentation/devicetree/bindings/leds/common.yaml > > +++ b/Documentation/devicetree/bindings/leds/common.yaml > > @@ -98,9 +98,13 @@ properties: > > # LED alters the brightness for the specified duration with one software > > # timer (requires "led-pattern" property) > > - pattern > > - # LED is triggered by SD/MMC activity > > - - pattern: "^mmc[0-9]+$" > > - pattern: "^cpu[0-9]*$" > > + - pattern: "^hci[0-9]+-power$" > > + # LED is triggered by Bluetooth activity > > + - pattern: "^mmc[0-9]+$" > > + # LED is triggered by SD/MMC activity > > + - pattern: "^phy[0-9]+tx$" > > + # LED is triggered by WLAN activity > > > > led-pattern: > > description: | > > Best regards, > Krzysztof > -- Luiz Augusto von Dentz
