On Fri, Jan 20, 2023 at 10:50:35AM +0100, Herve Codina wrote: > +static int idt821034_kctrl_gain_put(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol) > +{ > + struct soc_mixer_control *mc = (struct soc_mixer_control *)kcontrol->private_value; > + struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol); > + struct idt821034 *idt821034 = snd_soc_component_get_drvdata(component); > + struct idt821034_amp *amp; > + > + amp->gain = val; > + ret = 0; > +end: > + mutex_unlock(&idt821034->mutex); > + return ret; _put() methods should return 1 if the value changed to generate events - if you use the mixer-test selftest it'll spot this and other issues for you. Otherwise this looks fine.
Attachment:
signature.asc
Description: PGP signature