Re: [PATCH 2/3] ASoC: google: dt-bindings: sc7280: Add platform property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 1/19/2023 5:43 PM, Krzysztof Kozlowski wrote:
On 19/01/2023 07:11, Srinivasa Rao Mandadapu wrote:
Update sc7280 machine driver bindings with platform property for
supporting ADSP based platform's DAI links.
Subject:
ASoC: dt-bindings: google,sc7280-herobrine:

Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
Tested-by: Ratna Deepthi Kudaravalli <quic_rkudarv@xxxxxxxxxxx>
This tested tag is a bit unusual. How were they tested? If
dt_bindings_check why this is not the same person as you (submitter)?
Okay. Will remove Tested-by tag.

---
  .../devicetree/bindings/sound/google,sc7280-herobrine.yaml    | 11 +++++++++++
  1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
index 869b403..ccf1b1d 100644
--- a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
+++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
@@ -75,6 +75,17 @@ patternProperties:
additionalProperties: false + platform:
+        description: Holds subnode which indicates platform dai.
Neither commit msg nor this here explains why do you need it and what it
really represents. Basically description repeats "platform" name of
property - there is no single new information.
Will modify accordingly and re-spin.

+        type: object
+        properties:
+          sound-dai: true
maxItems
Sorry. why max items required here?

+
+        required:
+          - sound-dai
+
+        additionalProperties: false
+
      required:
        - link-name
        - cpu
Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux