Hi Keguang, I love your patch! Yet something to improve: [auto build test ERROR on 1b929c02afd37871d5afb9d498426f83432e71c2] url: https://github.com/intel-lab-lkp/linux/commits/Keguang-Zhang/dt-bindings-clock-Add-binding-for-Loongson-1-clock-driver/20230113-192017 base: 1b929c02afd37871d5afb9d498426f83432e71c2 patch link: https://lore.kernel.org/r/20230113110738.1505973-3-keguang.zhang%40gmail.com patch subject: [PATCH 2/2] clk: loongson1: Refactor to add devicetree support config: mips-loongson1b_defconfig (https://download.01.org/0day-ci/archive/20230119/202301191914.Rs7JrOPY-lkp@xxxxxxxxx/config) compiler: mipsel-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/b753dca857d9c85e25ba410fe013b78c7c73ca40 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Keguang-Zhang/dt-bindings-clock-Add-binding-for-Loongson-1-clock-driver/20230113-192017 git checkout b753dca857d9c85e25ba410fe013b78c7c73ca40 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All error/warnings (new ones prefixed by >>): >> drivers/clk/clk-loongson1.c:115:23: warning: no previous prototype for 'ls1x_clk_hw_register_pll' [-Wmissing-prototypes] 115 | struct clk_hw *__init ls1x_clk_hw_register_pll(struct device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/clk/clk-loongson1.c: In function 'ls1x_divider_set_rate': >> drivers/clk/clk-loongson1.c:186:13: warning: the comparison will always evaluate as 'true' for the address of 'lock' will never be NULL [-Waddress] 186 | if (÷r->lock) | ^ drivers/clk/clk-loongson1.c:28:20: note: 'lock' declared here 28 | spinlock_t lock; /* protect access to DIV registers */ | ^~~~ drivers/clk/clk-loongson1.c:212:13: warning: the comparison will always evaluate as 'true' for the address of 'lock' will never be NULL [-Waddress] 212 | if (÷r->lock) | ^ drivers/clk/clk-loongson1.c:28:20: note: 'lock' declared here 28 | spinlock_t lock; /* protect access to DIV registers */ | ^~~~ drivers/clk/clk-loongson1.c: At top level: >> drivers/clk/clk-loongson1.c:226:23: warning: no previous prototype for 'ls1x_clk_hw_register_divider' [-Wmissing-prototypes] 226 | struct clk_hw *__init ls1x_clk_hw_register_divider(struct device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/clk/clk-loongson1.c:310:34: warning: 'ls1x_divider_match' defined but not used [-Wunused-const-variable=] 310 | static const struct of_device_id ls1x_divider_match[] __initconst = { | ^~~~~~~~~~~~~~~~~~ drivers/clk/clk-loongson1.c:275:34: warning: 'ls1x_pll_match' defined but not used [-Wunused-const-variable=] 275 | static const struct of_device_id ls1x_pll_match[] __initconst = { | ^~~~~~~~~~~~~~ -- mipsel-linux-ld: arch/mips/loongson32/common/time.o: in function `plat_time_init': >> time.c:(.init.text+0x8): undefined reference to `ls1x_clk_init' -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests