On Tue, Jan 10, 2023 at 11:50:14PM +0800, Yang Xiwen wrote:
> This commit adds support for the ufi-001C and uf896 WiFi/LTE dongle made by
> unknown manufactures based on MSM8916.
> uf896 is another variant for the zhihe usb stick. The board design
> difers by using different gpios for the keys and leds.
>
> Note: The original firmware does not support 64-bit OS. It is necessary
> to flash 64-bit TZ firmware to boot arm64.
>
> Currently supported:
> - All CPU cores
> - Buttons
> - LEDs
> - Modem
> - SDHC
> - USB Device Mode
> - UART
>
> Co-developed-by: Jaime Breva <jbreva@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jaime Breva <jbreva@xxxxxxxxxxxxxxxx>
> Co-developed-by: Nikita Travkin <nikita@xxxxxxx>
> Signed-off-by: Nikita Travkin <nikita@xxxxxxx>
> Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 2 +
> .../boot/dts/qcom/msm8916-zhihe-uf896.dts | 41 +++
> .../boot/dts/qcom/msm8916-zhihe-ufi001c.dts | 39 +++
> arch/arm64/boot/dts/qcom/msm8916-zhihe.dtsi | 246 ++++++++++++++++++
> 4 files changed, 328 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8916-zhihe-uf896.dts
> create mode 100644 arch/arm64/boot/dts/qcom/msm8916-zhihe-ufi001c.dts
> create mode 100644 arch/arm64/boot/dts/qcom/msm8916-zhihe.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index b42362c7be1bf..7abc7bb19c9fc 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -21,6 +21,8 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-e7.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-grandmax.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8916-zhihe-uf896.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8916-zhihe-ufi001c.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-daisy.dtb
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-zhihe-uf896.dts b/arch/arm64/boot/dts/qcom/msm8916-zhihe-uf896.dts
> new file mode 100644
> index 0000000000000..2ddceb1d8b210
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8916-zhihe-uf896.dts
> @@ -0,0 +1,41 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +/dts-v1/;
> +
> +#include "msm8916-zhihe.dtsi"
> +
> +/ {
> + model = "uf896 4G Modem Stick";
> + compatible = "zhihe,uf896", "qcom,msm8916";
> +};
> +
> +&button_restart {
Please sort nodes alphabetically.
> + gpios = <&msmgpio 35 GPIO_ACTIVE_LOW>;
> +};
> +
> +&led_r {
> + gpios = <&msmgpio 82 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&led_g {
> + gpios = <&msmgpio 83 GPIO_ACTIVE_HIGH>;
> + function = LED_FUNCTION_WLAN;
> +};
> +
> +&led_b {
> + gpios = <&msmgpio 81 GPIO_ACTIVE_HIGH>;
> + function = LED_FUNCTION_WAN;
> +};
> +
> +&button_default {
> + pins = "gpio35";
> + bias-pull-up;
> +};
> +
> +&gpio_leds_default {
> + pins = "gpio81", "gpio82", "gpio83";
> +};
> +
> +&sim_ctrl_default {
> + pins = "gpio1", "gpio2";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-zhihe-ufi001c.dts b/arch/arm64/boot/dts/qcom/msm8916-zhihe-ufi001c.dts
> new file mode 100644
> index 0000000000000..715874a2b8650
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8916-zhihe-ufi001c.dts
> @@ -0,0 +1,39 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +/dts-v1/;
> +
> +#include "msm8916-zhihe.dtsi"
> +
> +/ {
> + model = "ufi-001c/ufi-001b 4G Modem Stick";
> + compatible = "zhihe,ufi001c", "qcom,msm8916";
> +};
> +
> +&button_restart {
> + gpios = <&msmgpio 37 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&led_r {
> + gpios = <&msmgpio 22 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&led_g {
> + gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&led_b {
> + gpios = <&msmgpio 20 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&button_default {
Same here, please sort alphabetically.
Regards,
Bjorn
