On 18.01.2023 09:55, Neil Armstrong wrote: > Add nodes for the Visionox VTDR6130 found on the SM8550-MTP > device. > > TLMM states are also added for the Panel reset GPIO and > Tearing Effect signal for when the panel is running in > DSI Command mode. > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 56 +++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index 0dfd1d3db86c..2de387aa2c2d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -370,6 +370,34 @@ &mdss { > &mdss_dsi0 { > vdda-supply = <&vreg_l3e_1p2>; > status = "okay"; > + > + panel@0 { > + compatible = "visionox,vtdr6130"; > + reg = <0>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sde_dsi_active>, <&sde_te_active>; > + pinctrl-1 = <&sde_dsi_suspend>, <&sde_te_suspend>; Hm.. I've just realized there are two styles of specifying phandle arrays: <&a &b> and <&a>, <&b>.. even worse, we have both of them in our tree.. Krzysztof, Bjorn, which one should we go with, going forward? > + > + vddio-supply = <&vreg_l12b_1p8>; > + vci-supply = <&vreg_l13b_3p0>; > + vdd-supply = <&vreg_l11b_1p2>; > + > + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; > + > + status = "okay"; Superfluous, it's enabled by default, drop Konrad > + > + port { > + panel0_in: endpoint { > + remote-endpoint = <&mdss_dsi0_out>; > + }; > + }; > + }; > +}; > + > +&mdss_dsi0_out { > + remote-endpoint = <&panel0_in>; > + data-lanes = <0 1 2 3>; > }; > > &mdss_dsi0_phy { > @@ -415,6 +443,34 @@ &sleep_clk { > > &tlmm { > gpio-reserved-ranges = <32 8>; > + > + sde_dsi_active: sde-dsi-active-state { > + pins = "gpio133"; > + function = "gpio"; > + drive-strength = <8>; > + bias-disable; > + }; > + > + sde_dsi_suspend: sde-dsi-suspend-state { > + pins = "gpio133"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + > + sde_te_active: sde-te-active-state { > + pins = "gpio86"; > + function = "mdp_vsync"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + > + sde_te_suspend: sde-te-suspend-state { > + pins = "gpio86"; > + function = "mdp_vsync"; > + drive-strength = <2>; > + bias-pull-down; > + }; > }; > > &uart7 { >