On 18/01/2023 00:16, Marek Vasut wrote:
> Add binding for Skyworks Si521xx PCIe clock generators. This binding
> is designed to support Si52144/Si52146/Si52147 series I2C PCIe clock
> generators, tested model is Si52144. It should be possible to add
> Si5213x series as well.
>
Thank you for your patch. There is something to discuss/improve.
> + '#clock-cells':
> + const: 1
> +
> + clocks:
> + items:
> + - description: XTal input clock
> +
> + skyworks,out-amplitude-microvolt:
> + enum: [ 300000, 400000, 500000, 600000, 700000, 800000, 900000, 1000000 ]
> + description: Output clock signal amplitude
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c@0 {
Just i2c {
> + reg = <0x0 0x100>;
And drop this one.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof
