[AMD Official Use Only - General] > -----Original Message----- > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > Sent: Tuesday, January 17, 2023 7:38 PM > To: Gupta, Nipun <Nipun.Gupta@xxxxxxx> > Cc: robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; rafael@xxxxxxxxxx; > eric.auger@xxxxxxxxxx; alex.williamson@xxxxxxxxxx; cohuck@xxxxxxxxxx; > song.bao.hua@xxxxxxxxxxxxx; mchehab+huawei@xxxxxxxxxx; maz@xxxxxxxxxx; > f.fainelli@xxxxxxxxx; jeffrey.l.hugo@xxxxxxxxx; saravanak@xxxxxxxxxx; > Michael.Srba@xxxxxxxxx; mani@xxxxxxxxxx; yishaih@xxxxxxxxxx; > jgg@xxxxxxxx; jgg@xxxxxxxxxx; robin.murphy@xxxxxxx; will@xxxxxxxxxx; > joro@xxxxxxxxxx; masahiroy@xxxxxxxxxx; ndesaulniers@xxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-kbuild@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; okaya@xxxxxxxxxx; > Anand, Harpreet <harpreet.anand@xxxxxxx>; Agarwal, Nikhil > <nikhil.agarwal@xxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>; git > (AMD-Xilinx) <git@xxxxxxx> > Subject: Re: [PATCH 04/19] bus/cdx: add MCDI protocol interface for firmware > interaction > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Tue, Jan 17, 2023 at 07:11:36PM +0530, Nipun Gupta wrote: > > +/** Request/Response structure */ > > +#define MCDI_HEADER_OFST 0 > > +#define MCDI_HEADER_CODE_LBN 0 > > +#define MCDI_HEADER_CODE_WIDTH 7 > > +#define MCDI_HEADER_RESYNC_LBN 7 > > +#define MCDI_HEADER_RESYNC_WIDTH 1 > > +#define MCDI_HEADER_DATALEN_LBN 8 > > +#define MCDI_HEADER_DATALEN_WIDTH 8 > > +#define MCDI_HEADER_SEQ_LBN 16 > > +#define MCDI_HEADER_SEQ_WIDTH 4 > > +#define MCDI_HEADER_RSVD_LBN 20 > > +#define MCDI_HEADER_RSVD_WIDTH 1 > > +#define MCDI_HEADER_NOT_EPOCH_LBN 21 > > +#define MCDI_HEADER_NOT_EPOCH_WIDTH 1 > > +#define MCDI_HEADER_ERROR_LBN 22 > > +#define MCDI_HEADER_ERROR_WIDTH 1 > > +#define MCDI_HEADER_RESPONSE_LBN 23 > > +#define MCDI_HEADER_RESPONSE_WIDTH 1 > > +#define MCDI_HEADER_XFLAGS_LBN 24 > > +#define MCDI_HEADER_XFLAGS_WIDTH 8 > > <snip> > > This whole file could use some tabs to align all of the values for the > defines to make it readable. Any chance of doing that? Yes sure. Will update this. > > thanks, > > greg k-h
