On Fri, Nov 07, 2014 at 05:15:38PM +0100, Javier Martinez Canillas wrote:
> On 11/07/2014 04:47 PM, Mark Brown wrote:
> >> + if (!of_property_read_u32(np, "regulator-initial-mode", &pval)) {
> >> + if (desc && desc->map_modes)
> >> + constraints->initial_mode = desc->map_modes(pval);
> >> + else
> >> + pr_warn("%s: failed to parse regulator-initial-mode\n",
> >> + np->name);
> >> + }
> > This is ignoring any error return from map_modes(), it's possible the DT
> > might have an invalid value. The error message could also use some
> > improvement, it's more that the kernel doesn't understand how to parse
> > it even if it is valid.
> Right, as I mentioned to Krzysztof in a previous email, I'll remove the
> warning message and add an error message instead if the map mode callback
> function fails and also show the error code as you suggest.
It seems reasonable to at least warn if there's a mode specified and
there's no way of understanding it...
Attachment:
signature.asc
Description: Digital signature
